Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wires final (merge second) #330

Merged
merged 33 commits into from
Feb 9, 2024
Merged

Wires final (merge second) #330

merged 33 commits into from
Feb 9, 2024

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented Jan 28, 2024

Context:
MM 1.0 refactoring

Description of the Change:
Adds Wires class for future use.

Benefits:
Wires enable easy handling of an circuit component's connectivity.

Possible Drawbacks:
New APIs

Related GitHub Issues:
None

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ab1f82d) 84.14% compared to head (18ed034) 84.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
+ Coverage    84.14%   84.46%   +0.32%     
===========================================
  Files           65       66       +1     
  Lines         4775     4900     +125     
===========================================
+ Hits          4018     4139     +121     
- Misses         757      761       +4     
Files Coverage Δ
mrmustard/lab/abstract/state.py 92.37% <ø> (ø)
mrmustard/lab_dev/wires.py 96.80% <96.80%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1f82d...18ed034. Read the comment docs.

Copy link
Contributor

@SamFerracin SamFerracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of files to remove

@ziofil ziofil changed the title Wires final Wires final (merge second) Feb 1, 2024
**Description of the Change:**
Tests and docs for wires final

---------

Co-authored-by: Yuan <16817699+sylviemonet@users.noreply.github.com>
Co-authored-by: ziofil <miatto@gmail.com>
Co-authored-by: Filippo Miatto <ziofil@users.noreply.github.com>
Copy link
Contributor

@SamFerracin SamFerracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change, all the rest is good :)

mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
@ziofil ziofil merged commit 312d7e2 into develop Feb 9, 2024
8 checks passed
@ziofil ziofil deleted the wires-final branch February 9, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants