-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wires final (merge second) #330
Conversation
Part of MM 1.0 refactor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #330 +/- ##
===========================================
+ Coverage 84.14% 84.46% +0.32%
===========================================
Files 65 66 +1
Lines 4775 4900 +125
===========================================
+ Hits 4018 4139 +121
- Misses 757 761 +4
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of files to remove
**Description of the Change:** Tests and docs for wires final --------- Co-authored-by: Yuan <16817699+sylviemonet@users.noreply.github.com> Co-authored-by: ziofil <miatto@gmail.com> Co-authored-by: Filippo Miatto <ziofil@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change, all the rest is good :)
Co-authored-by: SamFerracin <samuele.ferracin@xanadu.ai>
Context:
MM 1.0 refactoring
Description of the Change:
Adds
Wires
class for future use.Benefits:
Wires
enable easy handling of an circuit component's connectivity.Possible Drawbacks:
New APIs
Related GitHub Issues:
None