add triples.py file in the physics #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #338 +/- ##
===========================================
+ Coverage 84.46% 84.88% +0.41%
===========================================
Files 66 67 +1
Lines 4900 5035 +135
===========================================
+ Hits 4139 4274 +135
Misses 761 761
Continue to review full report in Codecov by Sentry.
|
SamFerracin
reviewed
Feb 7, 2024
Co-authored-by: SamFerracin <samuele.ferracin@xanadu.ai>
…nto ABC_triples
…d the corresponding tests
SamFerracin
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
This looks good to me now. Take a look and merge whenever you feel it's ready :)
Question:
- Are we missing some tests? Especially on those functions that do something non-trivial to the input parameters to change their lengths, or on those that do the math.block thing
ziofil
reviewed
Feb 13, 2024
ziofil
reviewed
Feb 13, 2024
ziofil
reviewed
Feb 13, 2024
ziofil
approved these changes
Feb 13, 2024
…nto ABC_triples
Merged
SamFerracin
pushed a commit
that referenced
this pull request
Feb 28, 2024
### New features * Added functions to generate the ``(A, b, c)`` triples for the Fock-Bargmann representation of several states and gates. [(#338)](#338) ### Breaking changes ### Improvements ### Bug fixes * Fixing a bug in `_transform_gaussian` in transformation.py that modifies the input state's cov and means. [(#349)](#349) * Fixing a bug in `general_dyne` in physics/gaussian.py that returns the wrong probability and outcomes with given projection. [(#349)](#349) ### Documentation ### Tests ### Contributors @SamFerracin @ziofil @sylviemonet --------- Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> Co-authored-by: JacobHast <jacobhastrup@gmail.com> Co-authored-by: elib20 <53090166+elib20@users.noreply.github.com> Co-authored-by: ziofil <ziofil@users.noreply.github.com> Co-authored-by: ziofil <miatto@gmail.com> Co-authored-by: Luke Helt <31250931+heltluke@users.noreply.github.com> Co-authored-by: zeyueN <48225584+zeyueN@users.noreply.github.com> Co-authored-by: Robbe De Prins <52749580+rdprins@users.noreply.github.com> Co-authored-by: Robbe De Prins (UGent-imec) <Robbe.DePrins@UGent.be> Co-authored-by: Yuan <16817699+sylviemonet@users.noreply.github.com> Co-authored-by: Ryk <47638463+ryk-wolf@users.noreply.github.com> Co-authored-by: Gabriele Gullì <120967042+ggulli@users.noreply.github.com> Co-authored-by: Yuan Yao <yuan.yao@xanadu-Yuan-YAO.local> Co-authored-by: Yuan Yao <yuan.yao@xanadu-infras-MacBook-Air.local> Co-authored-by: heltluke <luke.helt@gmail.com> Co-authored-by: Tanner Rogalsky <tanner@tannerrogalsky.com> Co-authored-by: Jan Provazník <101715194+jan-provaznik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Add a new file triples.py in the physics module to include all triples in Bargmann representations of the states and transformations.
This PR will set up the basic physics for Bargmann objects.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: