Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from state plotter #343

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Remove warnings from state plotter #343

merged 2 commits into from
Feb 8, 2024

Conversation

SamFerracin
Copy link
Contributor

Context:

from mrmustard.lab import *
Vacuum(1)

Executing the code above triggers a long list of annoying warnings, displayed between the recap of the state and the phase-space plot.

Description of the Change:
This PR removes the cause of the warnings, without changing the way that the plot looks

@SamFerracin SamFerracin added the no changelog Pull request does not require a CHANGELOG entry label Feb 8, 2024
@sylviemonet
Copy link
Contributor

Tbh, I can not reproduce the same warnings on my dev container in the branch develop.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (429b16c) 84.14% compared to head (7a76be4) 84.14%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #343   +/-   ##
========================================
  Coverage    84.14%   84.14%           
========================================
  Files           65       65           
  Lines         4775     4775           
========================================
  Hits          4018     4018           
  Misses         757      757           
Files Coverage Δ
mrmustard/lab/abstract/state.py 92.37% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429b16c...7a76be4. Read the comment docs.

@SamFerracin SamFerracin merged commit db1f4d5 into develop Feb 8, 2024
8 checks passed
@SamFerracin SamFerracin deleted the more-warns branch February 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants