Fix nonumerics in for-loops #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 97.16% 97.17% +0.01%
==========================================
Files 12 12
Lines 1902 1914 +12
==========================================
+ Hits 1848 1860 +12
Misses 54 54
Continue to review full report at Codecov.
|
josh146
previously approved these changes
Apr 5, 2021
Comment on lines
836
to
852
| def test_for_bool(self, parse_input_mocked_metadata): | ||
| """Test that a for-loop over a list containing bools is parsed correctly""" | ||
| bb = parse_input_mocked_metadata( | ||
| "for bool b in [True, False]\n\tMeasureFock() | 0" | ||
| ) | ||
| assert np.all( | ||
| bb._forvar["b"] == np.array([True, False]) | ||
| ) | ||
|
|
||
| def test_for_str(self, parse_input_mocked_metadata): | ||
| """Test that a for-loop over a list containing strings is parsed correctly""" | ||
| bb = parse_input_mocked_metadata( | ||
| 'for str s in ["one", "two"]\n\tMeasureFock() | 0' | ||
| ) | ||
| assert np.all( | ||
| bb._forvar["s"] == np.array(["one", "two"]) | ||
| ) |
There was a problem hiding this comment.
Nice tests, although, should they also be testing for the case where the boolean for loop variable is used within the loop?
There was a problem hiding this comment.
Updated the test to use the bool inside the loop. Not sure if there's another way of testing it. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using bool or string in for loop iterators isn't working properly. Currently, it returns None, instead of the wanted string or bool. This PR fixes the issue, so that e.g. the following works.