Bosonic engine results #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows for multiple shots for measurements (new test) - Raises an error if symbolic non-Gaussian state prep is attempted
Defines the BosonicEngine class Co-Authored-By: ilan-tz <57886357+ilan-tz@users.noreply.github.com> Co-Authored-By: Josh Izaac <josh@iza.ac> Co-Authored-By: Nicolas Quesada <991946+nquesada@users.noreply.github.com>
Ancilla samples are produced by ancillary modes used for measurement-based gates
Updates/adds new integration tests to apply to the bosonic backend
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 98.19% 98.22% +0.03%
==========================================
Files 76 76
Lines 8329 8360 +31
==========================================
+ Hits 8179 8212 +33
+ Misses 150 148 -2
Continue to review full report at Codecov.
|
boosts code coverage
Deletes the run method from the BosonicEngine, since it can be inherited from LocalEngine with a minimal change.
elib20
requested review from
antalszava,
josh146,
nquesada,
thisac and
ishdhand
nquesada
reviewed
Feb 24, 2021
nquesada
reviewed
Feb 24, 2021
josh146
reviewed
Feb 24, 2021
antalszava
reviewed
Feb 24, 2021
There was a problem hiding this comment.
@elib20 Looking good, no major blockers! 👍 Left some questions and suggestions, curious to get those addressed and could go for another round.
Co-authored-by: antalszava <antalszava@gmail.com>
- discovered and fixed bug in array dimension of returned samples - makes tests more readable - adds ancilla information to string of Results __repr__ - adds BosonicEngine to docs Co-Authored-By: antalszava <24476053+antalszava@users.noreply.github.com>
thisac
reviewed
Feb 24, 2021
Co-Authored-By: Theodor <6934626+thisac@users.noreply.github.com>
antalszava
reviewed
Feb 25, 2021
Co-authored-by: antalszava <antalszava@gmail.com>
Co-Authored-By: antalszava <24476053+antalszava@users.noreply.github.com>
…strawberryfields into bosonic-engine_results
thisac
approved these changes
Feb 26, 2021
| @@ -555,7 +679,6 @@ def test_Pgate_decomp_equal(self, setup_eng, s, tol): | |||
| eng.run(prog) | |||
| assert np.all(eng.backend.is_vacuum(tol)) | |||
|
|
|||
| @pytest.mark.backends("fock","tf","gaussian") | |||
There was a problem hiding this comment.
Are these removed since they run on all backends?
There was a problem hiding this comment.
Yes! The conftest file defaults to run tests on all backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The bosonic backend is useful for simulating bosonic qubits.
Description of the Change:
Benefits:
Running Programs on the bosonic backend from the frontend using an engine.
Possible Drawbacks:
Related GitHub Issues: