-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt the Xanadu Sphinx Theme #701
Conversation
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 75 75
Lines 9225 9225
=======================================
Hits 9107 9107
Misses 118 118
Continue to review full report at Codecov.
|
❤️ A couple of things I noticed while browsing around:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, @josh146!
Nice catch! 🎣 I've updated the theme to support custom
Another great observation! 🔎 This has been fixed in the latest version of the centralized Xanadu Sphinx Theme. |
Thanks, @thisac!
Good eye! 👁 I don't think this would be too difficult to fix; however, I would prefer to just remove the tooltips as they (mostly) just repeat the title of the gallery item anyway.
Yes, agreed, although I stand by the decision to use a consistent font across all of our OSS projects to ensure the Sphinx assets look crisp and unified. If only we had access to the Xanadu wordmark font... |
Thanks @Mandrenkov! |
Context:
Currently, all Xanadu OSS projects include their own version of the Xanadu Sphinx theme; however, the Xanadu Sphinx Theme repository is now publicly available and is the preferred way to access the Xanadu CSS theme and Sphinx directives.
Description of the Change:
Benefits:
git clone
will run faster.Possible Drawbacks:
None.
Related GitHub Issues:
Depends on XanaduAI/xanadu-sphinx-theme#2.
Note to Reviewers:
The Install and Circuits pages capture most of the representative changes between the Sphinx themes.