Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license file to distribution #20

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Add license file to distribution #20

merged 3 commits into from
Jan 20, 2022

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented Jan 20, 2022 •
edited
Loading

Context: Currently, the license file is not included in the distribution.

Description of the Change: The license file is now included in the distribution.

Benefits: Downstream distributors don't need to separately download the license.

Possible Drawbacks:

Related GitHub Issues:

@BastianZim
Copy link
Contributor Author

Similar to XanaduAI/xir#11

@BastianZim BastianZim marked this pull request as ready for review January 20, 2022 14:47
Mandrenkov
Mandrenkov approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me. 👍

@Mandrenkov Mandrenkov merged commit 720e714 into XanaduAI:main Jan 20, 2022
@BastianZim BastianZim deleted the add-license branch January 20, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mandrenkov Mandrenkov Mandrenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BastianZim @Mandrenkov