-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream job results in chunks #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Since everything is now streamed I'm assuming that streaming small files isn't any slower than before?
Thanks for the review, @doctorperceptron!
Excellent question! To check if this is the case, I submitted a small job and fetched the results 10 times using this branch as well as
The results show there is no significant difference in the fetching time of this job between the branches. Branch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! 🚀
Context:
Currently, fetching large job results (e.g., those on the order of GBs) can take an unreasonably long time due to the memory overhead associated with the default fetching strategy of the requests library. Fetching the same job result from a web browser (e.g., Firefox) tends to be much faster presumably due to the streaming nature of the download.
Description of the Change:
stream
keyword argument during error handling.Benefits:
Possible Drawbacks:
None.
Related GitHub Issues:
None.