Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong translation on loading strings #69

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

XanatosX
Copy link
Owner

@XanatosX XanatosX commented Feb 21, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #66

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check if the translation for the theme is working now
  • Check if the translation for the hotkeys is correct as well
  • Check if the application is still getting build without issues

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@XanatosX XanatosX marked this pull request as ready for review February 21, 2023 19:14
@XanatosX XanatosX merged commit ee72e0e into develop Feb 21, 2023
@XanatosX XanatosX mentioned this pull request Feb 21, 2023
5 tasks
@XanatosX XanatosX deleted the bugfix/66-fix-theme-language-not-changed branch August 3, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] If language is changed the theme name will stay on the old language
1 participant