Skip to content

Commit

Permalink
refactor: Remove unused GrammarVisitor methods
Browse files Browse the repository at this point in the history
  • Loading branch information
Xanewok committed May 24, 2024
1 parent 0d1fda3 commit 645b05f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
2 changes: 0 additions & 2 deletions crates/codegen/runtime/generator/src/parser/grammar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ pub struct Grammar {

impl Grammar {
pub fn accept_visitor<V: GrammarVisitor>(&self, visitor: &mut V) {
visitor.grammar_enter(self);
for element in self.elements.values() {
element.accept_visitor(visitor);
}
visitor.grammar_leave(self);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ pub struct PrecedenceParserDefinitionNode {

impl Visitable for PrecedenceParserDefinitionNode {
fn accept_visitor<V: GrammarVisitor>(&self, visitor: &mut V) {
visitor.precedence_parser_definition_node_enter(self);
self.primary_expression.accept_visitor(visitor);
}
}
10 changes: 3 additions & 7 deletions crates/codegen/runtime/generator/src/parser/grammar/visitor.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
use crate::parser::grammar::{
Grammar, KeywordScannerDefinitionRef, ParserDefinitionNode, ParserDefinitionRef,
PrecedenceParserDefinitionNode, PrecedenceParserDefinitionRef, ScannerDefinitionNode,
ScannerDefinitionRef, TriviaParserDefinitionRef,
KeywordScannerDefinitionRef, ParserDefinitionNode, ParserDefinitionRef,
PrecedenceParserDefinitionRef, ScannerDefinitionNode, ScannerDefinitionRef,
TriviaParserDefinitionRef,
};

pub trait GrammarVisitor {
fn grammar_enter(&mut self, _grammar: &Grammar) {}
fn grammar_leave(&mut self, _grammar: &Grammar) {}

fn scanner_definition_enter(&mut self, _scanner: &ScannerDefinitionRef) {}
fn keyword_scanner_definition_enter(&mut self, _scanner: &KeywordScannerDefinitionRef) {}
fn trivia_parser_definition_enter(&mut self, _trivia_parser: &TriviaParserDefinitionRef) {}
Expand All @@ -16,7 +13,6 @@ pub trait GrammarVisitor {

fn scanner_definition_node_enter(&mut self, _node: &ScannerDefinitionNode) {}
fn parser_definition_node_enter(&mut self, _node: &ParserDefinitionNode) {}
fn precedence_parser_definition_node_enter(&mut self, _node: &PrecedenceParserDefinitionNode) {}
}

pub trait Visitable {
Expand Down

0 comments on commit 645b05f

Please sign in to comment.