Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

locale: Text labels for some options #13

Merged
merged 4 commits into from
Nov 10, 2019
Merged

locale: Text labels for some options #13

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79377a1
Text labels for some options
UserNaem Nov 4, 2019
0fdeef7
Update en-US.ini
UserNaem Nov 6, 2019
1bcd384
Update en-US.ini
UserNaem Nov 6, 2019
6b66118
Update en-US.ini
UserNaem Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions data/locale/en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ KeyFrames="Key Frames"
KeyFrames.IntervalType="Interval Type"
KeyFrames.IntervalType.Frames="Frames"
KeyFrames.IntervalType.Seconds="Seconds"
KeyFrames.IntervalType.Description="Keyframe interval type"
KeyFrames.Interval.Description="Distance between key frames, in frames or seconds. Default is 2 seconds."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be best to remove the default value here, as it may change and can be better shown by OBS's UI code instead of being put into the tooltip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBS' UI doesn't offer an immediately apparent way to unset any changed settings to default, so I thought putting a note somewhere "if you broke it, here's how to unbreak" would help, but if you intend on putting it in later, this won't be useful.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but there's a need for a UI rework in OBS anyway. Including default values shouldn't be an issue once the decisions have been made there.

KeyFrames.Interval="Interval"

# Codec: H264
Expand All @@ -55,7 +57,9 @@ Codec.H264.Profile.baseline="Baseline"
Codec.H264.Profile.main="Main"
Codec.H264.Profile.high="High"
Codec.H264.Profile.high444p="High 4:4:4 Predictive"
Codec.H264.Profile.Description="H.264 profile determines which features of the codec can be used.\nHigh 4:4:4 Predictive is required for YUV 4:4:4 color space."
Codec.H264.Level="Level"
Codec.H264.Level.Description="Level determines the upper limits of resolution, frame rate and bitrate for the video."

# Codec: HEVC
Codec.HEVC="HEVC"
Expand All @@ -67,6 +71,7 @@ Codec.HEVC.Tier="Tier"
Codec.HEVC.Tier.main="Main"
Codec.HEVC.Tier.high="High"
Codec.HEVC.Level="Level"
Codec.HEVC.Level.Description="Level determines the upper limits of resolution, frame rate and bitrate for the video."

# Codec: Apple ProRes
Codec.ProRes.Profile="Profile"
Expand All @@ -79,6 +84,7 @@ Codec.ProRes.Profile.AP4X="4444 Extra Quality/XQ (AP4X)"

# NVENC
NVENC.Preset="Preset"
NVENC.Preset.Description="Presets are NVIDIA's preconfigured default settings."
NVENC.Preset.Default="Default"
NVENC.Preset.Slow="Slow"
NVENC.Preset.Medium="Medium"
Expand All @@ -93,7 +99,13 @@ NVENC.Preset.Lossless="Lossless"
NVENC.Preset.LosslessHighPerformance="Lossless High Performance"
NVENC.RateControl="Rate Control Options"
NVENC.RateControl.Mode="Mode"
NVENC.RateControl.Mode.CQP="Constant Quantization Parameter"
NVENC.RateControl.Mode.Description="Rate control mode selection"
NVENC.RateControl.Mode.CQP.Description="A flat compression ratio with no regard for bit rates.\nThis yields the highest quality-per-bitrate."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\nThis yields the highest quality-per-bitrate. since this depends on the users settings, don't include it.

NVENC.RateControl.Mode.VBR.Description="Sacrifices quality to stay below the upper bitrate limit,\nor saves bitrate where possible."
NVENC.RateControl.Mode.VBR_HQ.Description="Variable Bitrate with two-pass encoding enabled by default."
NVENC.RateControl.Mode.CBR.Description="Sacrifices quality in high-motion scenes and performs bit stuffing\nin low-motion scenes to maintain a constant bitrate."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually describe what CBR does, not how it works.

For example:

Compresses footage so that it matches the target bitrate over the duration of one second. This comes at a cost in quality during high motion scenes or scenes with flickering brightness like often seen in RPGs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of a good way to explain this myself, so I'll go with your description.

NVENC.RateControl.Mode.CBR_HQ.Description="Constant Bitrate with two-pass encoding enabled by default."
NVENC.RateControl.Mode.CBR_LD_HQ.Description="Constant Bitrate optimized for lowest encoding latency, mainly by disabling B-frames and using slice multithreading."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, mainly by disabling B-frames and using slice multithreading does not apply to NVENC unless you know how all NVENC chips work internally.

NVENC.RateControl.Mode.VBR="Variable Bitrate"
NVENC.RateControl.Mode.VBR_HQ="High Quality Variable Bitrate"
NVENC.RateControl.Mode.CBR="Constant Bitrate"
Expand All @@ -109,6 +121,7 @@ NVENC.RateControl.TwoPass="Enable Two Pass"
NVENC.RateControl.TwoPass.Description="Enable a secondary pass for encoding, which can help with quality and bitrate stability.\nImproves quality slightly at the cost of some GPU time.\nNvidia Turing hardware might actually see a quality degrade from this."
NVENC.RateControl.Bitrate="Bitrate Limits"
NVENC.RateControl.Bitrate.Target="Target Bitrate"
NVENC.RateControl.Bitrate.Target.Description="Target bitrate, in kilobits per second."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, in kilobits per second is part of the general UI, there should be a kbit/s suffix in the field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaves me with a tooltip that says "Target bitrate." I'll remove that, too.

NVENC.RateControl.Bitrate.Maximum="Maximum Bitrate"
NVENC.RateControl.Quality="Enable Quality Limits"
NVENC.RateControl.Quality.Minimum="Minimum Quality"
Expand Down Expand Up @@ -139,7 +152,7 @@ NVENC.AQ.Temporal="Enable Temporal Adaptive Quantization"
NVENC.AQ.Temporal.Description="Enable temporal adaptive quantization."
NVENC.Other="Other Options"
NVENC.Other.BFrames="Maximum B-Frames"
NVENC.Other.BFrames.Description="Maximum number of B-Frames to insert into the encoded bitstream.\nActual number of B-Frames may be lower depending on content and lookahead settings."
NVENC.Other.BFrames.Description="Maximum number of B-Frames to insert into the encoded bitstream.\nActual number of B-Frames may be lower depending on content and lookahead settings.\nOnly Turing NVENC supports B-Frames for HEVC."
NVENC.Other.BFrameReferenceMode="B-Frame Reference Mode"
NVENC.Other.BFrameReferenceMode.Each="Each B-Frame will be used for references"
NVENC.Other.BFrameReferenceMode.Middle="Only (# of B-Frames)/2 will be used for references"
Expand Down