Support SRP Login #640
Merged
Support SRP Login #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to use https://github.com/adam-fowler/swift-srp with some modifications that are local - Pad g value to equal size of N while calculating clientProof - Use SHA256(plain-text-password) while computing key using PBKDF2 - Added a unit test with some sample values
- Use from https://github.com/abiligiri/swift-srp, version 1.1.0 This is based on latest from upstream with changes required - Remove local copy of swift-srp
SRP Login works now
tsdevshop
reviewed
Oct 29, 2024
| products: [ | ||
| // Products define the executables and libraries a package produces, and make them visible to other packages. | ||
| .library( | ||
| name: "AppleAPI", | ||
| targets: ["AppleAPI"]), | ||
| ], | ||
| dependencies: [], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/xcodesOrg/swift-srp", branch: "main") |
There was a problem hiding this comment.
It might be better to depend on a particular commit rather than main, as this could cause issues if swift-srp introduces a change which is not compatible with the current app codebase.
Or does it make sense to package this up as a separate SRP package, something like icloud-srp? I imagine this will be useful for other people who need to authenticate with Apple's iCloud servers in Swift.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @abiligiri for figuring out the hard stuff