Add signout command #140
Merged
Add signout command #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses enhancement: XcodesOrg#136
MattKiazyk
approved these changes
Mar 17, 2021
Sources/AppleAPI/Client.swift
Outdated
| @@ -27,6 +28,8 @@ public class Client { | |||
| return "Not a valid phone number index. Expecting a whole number between \(min)-\(max), but was given \(given ?? "nothing")." | |||
| case .noTrustedPhoneNumbers: | |||
| return "Your account doesn't have any trusted phone numbers, but they're required for two-factor authentication. See https://support.apple.com/en-ca/HT204915." | |||
| case .notAuthenticated: | |||
| return "No authenticated session found" | |||
There was a problem hiding this comment.
Do you think the red is a little harsh for the error? It really just is an info statement. Perhaps the description here would be better a little less error like. You are already signed out ?
There was a problem hiding this comment.
I like both suggestions 👍
Implemented it in d49c722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses enhancement #136
What changed
A new
signoutcommand has been added to:defaultUsernamein Configuration to nil