Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved XIP expansion to a temporal directory #179

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Commits on Feb 6, 2022

  1. Moved XIP expansion to a temporal directory

    Instead of expanding XIPs on its current directory, a temporal directory is used. The main advantage of this approach is that, because the temporal directory is created on the same volume where Xcode will be installed, the installation is vastly improved if the XIP is on a different volume.
    
    - https://nshipster.com/temporary-files/
    - The implementation of the `temporalDirectory` function and variable are based on the similar `trashItem`, but without the `@discardableResult` annotation (I cannot think of any case where this URL could to be ignored).
    
    This closes XcodesOrg#178.
    juanjonol committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    239898f View commit details
    Browse the repository at this point in the history
  2. Moved logic to get the Xcode's expansion directory to a function insi…

    …de `Files`
    
    As suggested by @MattKiazyk, to be able to get the expansion directory by simply calling `Current.files.xcodeExpansionDirectory()`.
    
    - The `Files.temporalDirectory()` added on the previous commits is keep even if it's not used outside `Files.xcodeExpansionDirectory()`, to keep each function with a single statement (as the other functions on `Files`).
    - I'm not sure there's value on adding the `xcodeExpansionDirectory` variable, but added for consistency with the other functions on `Files`.
    juanjonol committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    f1163aa View commit details
    Browse the repository at this point in the history
  3. Added expand-xip-inplace flag to prevent expanding on a temporal di…

    …rectory
    
    As suggested by @MattKiazyk, to allow the user to revert to the old behaviour if needed.
    
    - For testing this flag is set to `true`, to use a well-known location when testing.
    - The `xcodeExpansionDirectory` function cannot be easily expressed on a single line anymore, so removed the variable added on the previous commit (which wasn’t used anyway).
    juanjonol committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    6fe3a3e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Merge tag '0.20.0' into xip-multivolume-expasion

    # Conflicts:
    #	Sources/XcodesKit/XcodeInstaller.swift
    #	Sources/xcodes/main.swift
    juanjonol committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    d5aead5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Merge tag '1.0.0' into xip-multivolume-expasion

    # Conflicts:
    #	Sources/XcodesKit/XcodeInstaller.swift
    #	Sources/xcodes/main.swift
    #	Tests/XcodesKitTests/XcodesKitTests.swift
    juanjonol committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    f4b45a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Merge tag '1.1.0' into xip-multivolume-expasion

    # Conflicts:
    #	Sources/XcodesKit/XcodeInstaller.swift
    #	Sources/xcodes/App.swift
    juanjonol committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    4832c8d View commit details
    Browse the repository at this point in the history
  2. Merge tag '1.2.0' into xip-multivolume-expasion

    # Conflicts:
    #	Sources/XcodesKit/Environment.swift
    #	Sources/XcodesKit/XcodeInstaller.swift
    #	Sources/xcodes/App.swift
    #	Tests/XcodesKitTests/Environment+Mock.swift
    #	Tests/XcodesKitTests/XcodesKitTests.swift
    juanjonol committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    5beeccf View commit details
    Browse the repository at this point in the history
  3. Merge tag '1.3.0' into xip-multivolume-expasion

    # Conflicts:
    #	Sources/xcodes/App.swift
    juanjonol committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    85b1219 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    16138af View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    ba722d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1696da6 View commit details
    Browse the repository at this point in the history