Add support for SRP Apple login #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsdevshop
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Is it possible to add any tests for this new flow? Similar to those in the Xcodes.app repo
|
@MattKiazyk , I've run this locally to download the 16.2 Beta and it worked for me Here's what I did: I think this should have tested the flow that you changed, right? |
spadafiva
reviewed
Oct 29, 2024
spadafiva
reviewed
Oct 29, 2024
spadafiva
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Fix is working for me and using the SRP login! Thanks @MattKiazyk
Edit: I have not validated the implementation aside from checking that it works. Happy to compare to a reference implementation or other documentation if you have a link/resource for me to compare to though!
MattKiazyk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple switched up their login to now use a Secure Remote Password type of algorithm. This add support for it, so a user can login properly.
Fixes #388