Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy is being activated even when the user clicks Cancel in the confirm() dialog #208

Closed
prem-k-r opened this issue Nov 23, 2024 · 5 comments · Fixed by #211
Closed

Proxy is being activated even when the user clicks Cancel in the confirm() dialog #208

prem-k-r opened this issue Nov 23, 2024 · 5 comments · Fixed by #211

Comments

@prem-k-r
Copy link
Collaborator

image
@itz-rj-here
Copy link
Collaborator

Wait what? That was not on our mind.
Will you fix the issue or i need to ?

@itz-rj-here
Copy link
Collaborator

Here is the line anyways

image

@prem-k-r
Copy link
Collaborator Author

Wait what? That was not on our mind. Will you fix the issue or i need to ?

please do
image
need to change in useproxyCheckbox.addEventListener too

@itz-rj-here
Copy link
Collaborator

Wait what? That was not on our mind. Will you fix the issue or i need to ?

please do image need to change in useproxyCheckbox.addEventListener too

Then I will do it tomorrow. Need to go to sleep now.

@XengShi
Copy link
Owner

XengShi commented Nov 23, 2024

Thanks for raising this issue, we need to fix that ASAP.

This was referenced Nov 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the Proxy Disclaimer Cancel Button Issue itz-rj-here/materialYouNewTab
3 participants
@XengShi @prem-k-r @itz-rj-here