Fixed the Proxy Disclaimer Cancel Button Issue #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prem-k-r
requested changes
Nov 24, 2024
Like this? @prem-k-r |
|
yep |
Co-Authored-By: Prem Kumar <60751338+prem-k-r@users.noreply.github.com>
|
Now? @prem-k-r |
|
@XengShi Are you still going to merge it? |
What did you mean "still going to merge....." ? |
He was probably being sarcastic, possibly asking when the merge will happen. |
|
Getting an error after enabling search suggestions without turning on the proxy bypass toggle. This error was already present before. |
|
Yeah from catch block, when browser blocked access due to cors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208
Bug Issue Fix Requested by @prem-k-r
Information about the fix: https://screenrec.com/share/QFIG9l4W7o