Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better spacing of theme and language for larger menu width #216

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 26, 2024

Also WeatherAPI transliteration corrected
and added Menu width for tr and changed for pt

for tr
image
to
image

for pt
image
image
changed to
image
image

WeatherAPI transliteration corrected
Menu width for tr and changed for pt
better spacing for larger menu width
Copy link
Collaborator

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good :)

@itz-rj-here
Copy link
Collaborator

Can you also add scrollbar for language selector too?
There are too many languages. So, I think we should add a scrollbar on the language selector.

@prem-k-r
Copy link
Collaborator Author

Can you also add scrollbar for language selector too? There are too many languages. So, I think we should add a scrollbar on the language selector.

There is, but it only pops up when options are about to go out from desktop, not tab

@prem-k-r
Copy link
Collaborator Author

See #184 XengShi comment for details

@itz-rj-here
Copy link
Collaborator

See #184 XengShi comment for details

I would have recommanded to add 5-6 language showup then others will be shown when going down using scroll bar. :|

@prem-k-r
Copy link
Collaborator Author

See #184 XengShi comment for details

I would have recommanded to add 5-6 language showup then others will be shown when going down using scroll bar. :|

I understand, I also wanted.. but have to make custom dropdown menu for it, we are using default html option right now.
Custom one will give all freedom like bgcolor which is blue right now. But I have no immediate plan of implementing it.. You can try if you want

@itz-rj-here
Copy link
Collaborator

See #184 XengShi comment for details

I would have recommanded to add 5-6 language showup then others will be shown when going down using scroll bar. :|

I understand, I also wanted.. but have to make custom dropdown menu for it, we are using default html option right now. Custom one will give all freedom like bgcolor which is blue right now. But I have no immediate plan of implementing it.. You can try if you want

Fine.

2nd approach, better spacing
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 27, 2024

Original:
image
changed to
image

@XengShi XengShi merged commit c1a4020 into XengShi:main Nov 28, 2024
@prem-k-r prem-k-r deleted the patch-1 branch November 28, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants