Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes related to icons and colors #220

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

prem-k-r
Copy link
Collaborator

  • Google apps color in black theme, more darker
    image
    to
    image

  • Checked radio button color in black theme, more darker
    image
    to
    image

  • Github svg bg white color, added slight transparency
    image
    to
    image

  • Resized Copilot icon to align with others
  • Added inward padding to Perplexity icon
    image
    to
    image

  • Changed Mail icon
  • Decreased Instagram main icon dimension
    image
    to
    image

It also resulted in
image
to
image

Changed white bg to slightly transparent
related to Copilot and Perplexity icons
change mail and instagram icon and dark theme color change
instagram stroke color
@prem-k-r
Copy link
Collaborator Author

image

@prem-k-r
Copy link
Collaborator Author

image
image
image
image

@XengShi
Copy link
Owner

XengShi commented Nov 28, 2024

image
image
image
image

2nd or 3rd is looking nicer than other

@prem-k-r
Copy link
Collaborator Author

image
image
image
image

2nd or 3rd is looking nicer than other

I agree, my first choice is 2nd one.. it is implemented in current pr
second choice is 3rd one, in case if you like that more... can replace

@prem-k-r
Copy link
Collaborator Author

Dark theme:
image

@XengShi
Copy link
Owner

XengShi commented Nov 28, 2024

IMG_20241128_143942.jpg

How about adding a little hint to add new shortcuts and when user clicks on + button, new shortcuts should appear on top because if have small screen then user won't be able to see any changes until scroll down.

@prem-k-r
Copy link
Collaborator Author

IMG_20241128_143942.jpg

How about adding a little hint to add new shortcuts and when user clicks on + button, new shortcuts should appear on top because if have small screen then user won't be able to see any changes until scroll down.

It's great.
Also someting like- Click on the shortcut name or URL to edit

@XengShi XengShi merged commit e8c33b2 into XengShi:main Nov 28, 2024
@prem-k-r prem-k-r deleted the patch-1 branch November 28, 2024 09:29
@XengShi
Copy link
Owner

XengShi commented Nov 28, 2024

what you deleted!

@prem-k-r
Copy link
Collaborator Author

what you deleted!

my branch

@XengShi
Copy link
Owner

XengShi commented Nov 28, 2024

what you deleted!

my branch

I merged that is that okay?

@prem-k-r
Copy link
Collaborator Author

what you deleted!

my branch

I merged that is that okay?

yep,
It was a branch in my fork, named patch-1 (default name)
https://github.com/prem-k-r/materialYouNewTab/branches

Github best practice is not to raise PR from main branch, instead from different branch
and may delete it after merge

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 28, 2024

IMG_20241128_143942.jpg

How about adding a little hint to add new shortcuts and when user clicks on + button, new shortcuts should appear on top because if have small screen then user won't be able to see any changes until scroll down.

Please replicate the changes in XengShi:main, I can take care of translation stuff if needed.

You may add this:

You can add new shortcuts by clicking the "+" icon or edit existing ones by clicking on the shortcut name or URL

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 28, 2024

Or this lol, if you want to include reset part too, else above one is already enough, I think

You can add new shortcuts by clicking the "+" icon, edit existing ones by clicking on the shortcut name or URL, or reset to default shortcuts by clicking the ↺ icon

@itz-rj-here
Copy link
Collaborator

what you deleted!

Chill out. Thats not that important at all. The branch is restorable if needed.
He does his changes in different branches. I build different. I do my changes in the main branch 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants