-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More themes: Brown, Light and Dark Grey #237
Conversation
The blue one is looking ugly but the others are nice 🙂 |
yep, need modifications, that's why not included for now |
are these ok? @XengShi |
Yess great specially brown and light gray |
@prem-k-r I am worrying about bookmarks thing. If we implement that in extension which requires unnecessary bookmarks permissions. |
how should we proceed? |
this, mentioning reason? |
I think we can simply show a message in menu page or when extension is loaded for the first time. "Press X+Y+B to view the bookmarks" We can detect the browser and operating system in javascript. For showing users appropriate shortcuts |
ok, but I won't suggest showing it right away, coz we already recieve a prompt to |
Guys, I'm working on it. I need some time tho. :( |
let's show alert until then |
It's your choice. |
https://screenrec.com/share/B1aKzH3VFn This is the thing i will try to implement for the bookmark. |
Thanks 😍 |
Demo: https://prem-k-r.github.io/materialYouNewTab/