Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More themes: Brown, Light and Dark Grey #237

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 30, 2024

later we can add 3 more dark themes
like
image

image
image
image

@XengShi
Copy link
Owner

XengShi commented Nov 30, 2024

The blue one is looking ugly but the others are nice 🙂

@prem-k-r
Copy link
Collaborator Author

The blue one is looking ugly but the others are nice 🙂

yep, need modifications, that's why not included for now

@prem-k-r
Copy link
Collaborator Author

image image image

image image

image image

Demo: prem-k-r.github.io/materialYouNewTab

are these ok? @XengShi

@XengShi
Copy link
Owner

XengShi commented Nov 30, 2024

Yess great specially brown and light gray

@XengShi
Copy link
Owner

XengShi commented Nov 30, 2024

IMG_20241130_210621.jpg

I think splinting the dark theme will enhance the appearance.

@itz-rj-here
Copy link
Collaborator

IMG_20241130_210621.jpg

I think splinting the dark theme will enhance the appearance.

Agreed

@prem-k-r
Copy link
Collaborator Author

IMG_20241130_210621.jpg

I think splinting the dark theme will enhance the appearance.

Alright, let's plan for that once more themes are added.
Please merge this if everything else is fine.

@XengShi
Copy link
Owner

XengShi commented Nov 30, 2024

@prem-k-r I am worrying about bookmarks thing.
It can be easily shown using ctrl+shift+B

If we implement that in extension which requires unnecessary bookmarks permissions.

@prem-k-r
Copy link
Collaborator Author

@prem-k-r I am worrying about bookmarks thing. It can be easily shown using ctrl+shift+B

If we implement that in extension which requires unnecessary bookmarks permissions.

how should we proceed?
even if we make make custom bookmark list, it's difficult to make it like real one.

@prem-k-r
Copy link
Collaborator Author

this, mentioning reason?
#222 (comment)

@XengShi
Copy link
Owner

XengShi commented Nov 30, 2024

I think we can simply show a message in menu page or when extension is loaded for the first time.

"Press X+Y+B to view the bookmarks"

We can detect the browser and operating system in javascript. For showing users appropriate shortcuts

@prem-k-r
Copy link
Collaborator Author

I think we can simply show a message in menu page or when extension is loaded for the first time.

"Press X+Y+B to view the bookmarks"

We can detect the browser and operating system in javascript. For showing users appropriate shortcuts

ok, but I won't suggest showing it right away, coz we already recieve a prompt to keep it or change back the home page

@itz-rj-here
Copy link
Collaborator

@prem-k-r I am worrying about bookmarks thing. It can be easily shown using ctrl+shift+B

If we implement that in extension which requires unnecessary bookmarks permissions.

Guys, I'm working on it. I need some time tho. :(

@prem-k-r
Copy link
Collaborator Author

@prem-k-r I am worrying about bookmarks thing. It can be easily shown using ctrl+shift+B
If we implement that in extension which requires unnecessary bookmarks permissions.

Guys, I'm working on it. I need some time tho. :(

let's show alert until then

@itz-rj-here
Copy link
Collaborator

@prem-k-r I am worrying about bookmarks thing. It can be easily shown using ctrl+shift+B
If we implement that in extension which requires unnecessary bookmarks permissions.

Guys, I'm working on it. I need some time tho. :(

let's show alert until then

It's your choice.

@itz-rj-here
Copy link
Collaborator

https://screenrec.com/share/B1aKzH3VFn

This is the thing i will try to implement for the bookmark.

@XengShi XengShi merged commit 69ac370 into XengShi:main Nov 30, 2024
@prem-k-r
Copy link
Collaborator Author

Thanks 😍

@prem-k-r prem-k-r deleted the more-themes branch November 30, 2024 21:41
@XengShi
Copy link
Owner

XengShi commented Dec 1, 2024

IMG_20241201_121349.jpg

Kindly improve the UI to match with other elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants