Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Senitize HTML In swapDropdown Method #294

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

princevora
Copy link
Contributor

@princevora princevora commented Dec 9, 2024

Description

Please describe your changes and the purpose of this pull request.

Related Issues

  • I Have tried to solve the senitize issue for swapDropdown function it is resolved

Checklist

  • I have read and followed the Contributing Guidelines.
  • I have added necessary tests.
  • The project builds and runs without issues.

@princevora princevora changed the title Issues/senitize html Senitize HTML In swapDropdown Method Dec 9, 2024
@prem-k-r
Copy link
Collaborator

prem-k-r commented Dec 9, 2024

Sorry I wasn't clear earlier,
image
There is no issue with funtionality.
There were two warnings in swapDropdown function related to security: Unsafe assignment to innerHTML, line 753 and 754.

@prem-k-r
Copy link
Collaborator

prem-k-r commented Dec 9, 2024

After the current changes that you have done in the PR, it should be resolved?

@princevora
Copy link
Contributor Author

After the current changes that you have done in the PR, it should be resolved?

It definitely should be. Can you tell me How can i validate that, i dont know the site actully.

@itz-rj-here
Copy link
Collaborator

After the current changes that you have done in the PR, it should be resolved?

It definitely should be. Can you tell me How can i validate that, i dont know the site actully.

Me too. Idk what is the site name could be ¿

@princevora
Copy link
Contributor Author

After the current changes that you have done in the PR, it should be resolved?

It definitely should be. Can you tell me How can i validate that, i dont know the site actully.

Me too. Idk what is the site name could be ¿

Its interface of the mozila developers page to submit addon but, i dont know the actual page

@prem-k-r
Copy link
Collaborator

prem-k-r commented Dec 9, 2024

After the current changes that you have done in the PR, it should be resolved?

It definitely should be. Can you tell me How can i validate that, i dont know the site actually.

Ok awesome..
Leave the validation, it's fine.. probably need to be registered as developer in Firefox...
XengShi can validate later

Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Great work

@XengShi XengShi merged commit 15254c7 into XengShi:main Dec 10, 2024
@princevora princevora deleted the issues/SenitizeHTML branch December 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants