expression: implement vectorized evaluation for builtin field(Real/In…

…t/String) (pingcap#13171)
XiaTianliang · Dec 21, 2019 · f84af94 · f84af94
1 parent 491f146
commit f84af94
Show file tree

Hide file tree

Showing 6 changed files with 425 additions and 25 deletions.
diff --git a/expression/builtin.go b/expression/builtin.go
@@ -18,6 +18,7 @@
 //go:generate go run generator/compare_vec.go
 //go:generate go run generator/control_vec.go
 //go:generate go run generator/other_vec.go
+//go:generate go run generator/string_vec.go
 //go:generate go run generator/time_vec.go
 
 package expression

diff --git a/expression/builtin_string_vec.go b/expression/builtin_string_vec.go
@@ -494,14 +494,6 @@ func (b *builtinLTrimSig) vecEvalString(input *chunk.Chunk, result *chunk.Column
 	return nil
 }
 
-func (b *builtinFieldStringSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinFieldStringSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinQuoteSig) vectorized() bool {
 	return true
 }
@@ -1078,14 +1070,6 @@ func (b *builtinInstrSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) e
 	return errors.Errorf("not implemented")
 }
 
-func (b *builtinFieldRealSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinFieldRealSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinOctStringSig) vectorized() bool {
 	return true
 }
@@ -1955,14 +1939,6 @@ func (b *builtinHexIntArgSig) vecEvalString(input *chunk.Chunk, result *chunk.Co
 	return nil
 }
 
-func (b *builtinFieldIntSig) vectorized() bool {
-	return false
-}
-
-func (b *builtinFieldIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
-}
-
 func (b *builtinFromBase64Sig) vectorized() bool {
 	return true
 }

diff --git a/expression/builtin_string_vec_generated.go b/expression/builtin_string_vec_generated.go
diff --git a/expression/builtin_string_vec_generated_test.go b/expression/builtin_string_vec_generated_test.go
diff --git a/expression/builtin_string_vec_test.go b/expression/builtin_string_vec_test.go
@@ -155,7 +155,6 @@ var vecBuiltinStringCases = map[string][]vecExprBenchCase{
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETString}},
 	},
 	ast.FindInSet: {},
-	ast.Field:     {},
 	ast.MakeSet: {
 		{retEvalType: types.ETString, childrenTypes: []types.EvalType{types.ETInt, types.ETString, types.ETString, types.ETString, types.ETString, types.ETString, types.ETString, types.ETString, types.ETString}},
 	},