This repository has been archived by the owner on May 10, 2022. It is now read-only.
bugfix: catch and rethrow BlockingOperationException for batchSet #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2019 17:17
neverchanje
requested review from
vagetablechicken,
acelyc111,
hycdong and
qinzuoyan
qinzuoyan
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user's bug of #50 still remains and it seems not a netty's bug.
I suspect it was due to some sort of deadlock or broken RPC that makes
Future.awaitUninterruptiblywaiting.The bug is unknown, but some improvements may still help:
Rethrow
BlockingOperationException(a try/catch block wraps aroundfuture.await) if user thread is in the same eventloop with netty. This is hardly a possible situation but may increase our robustness.Use
await(timeoutMillis)instead ofawaitUninterruptiblyto prevent the case we are unknown where the user's RPC is always incomplete but timeout is expired.