This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat: forbid large-size-value written to pegasus server #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Mar 17, 2020
levy5307
reviewed
Mar 17, 2020
src/main/java/com/xiaomi/infra/pegasus/rpc/async/TableHandler.java
Outdated
Show resolved
Hide resolved
foreverneverer
force-pushed
the
limit-size
branch
from
c1c0a38
to
e278198
Compare
levy5307
reviewed
Mar 20, 2020
|
I think it's enough to provide a simple boolean option "enableWriteSizeLimit" rather than "maxAllowedWriteSize". If there's some legacy or compatibility problem, the user can disable it and fix the write-size problem in the future. DynamoDB enforces a maximum size 400KB per item, and 16MB per batch. https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Limits.html. In terms of Pegasus, we can set limits on set and multiset separately. 400KB for set, and 1MB for multiset. |
neverchanje
reviewed
Apr 11, 2020
src/test/java/com/xiaomi/infra/pegasus/rpc/async/MetaSessionTest.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Apr 26, 2020
src/main/java/com/xiaomi/infra/pegasus/client/ClientOptions.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Apr 26, 2020
neverchanje
reviewed
Apr 26, 2020
neverchanje
reviewed
Apr 26, 2020
src/main/java/com/xiaomi/infra/pegasus/rpc/async/TableHandler.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Apr 26, 2020
foreverneverer
changed the title
foreverneverer
changed the title
foreverneverer
changed the title
neverchanje
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: XiaoMi/rdsn#414. This PR expect to forbid it at client side.
New config in
pegasus.properties:enable_write_limit = <true | false>