This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: change the type of prepare_list from raw pointer to std::unique_ptr #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
commented
Jan 20, 2022
| @@ -129,7 +129,7 @@ class replica_split_test : public replica_test_base | |||
| mu->set_logged(); | |||
| } | |||
| } | |||
| rep->_prepare_list = _mock_plist; | |||
There was a problem hiding this comment.
memory leak in previous implementation
levy5307
changed the title
hycdong
approved these changes
Jan 21, 2022
foreverneverer
approved these changes
Jan 21, 2022
Smityz
reviewed
Jan 21, 2022
| @@ -149,7 +149,7 @@ class mock_replica : public replica | |||
| void set_replica_config(replica_configuration &config) { _config = config; } | |||
| void set_partition_status(partition_status::type status) { _config.status = status; } | |||
| void set_last_committed_decree(decree d) { _prepare_list->reset(d); } | |||
| prepare_list *get_plist() { return _prepare_list; } | |||
| prepare_list *get_plist() const { return _prepare_list.get(); } | |||
There was a problem hiding this comment.
why not return unique_ptr directly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::unique_ptrto avoid memory leak, for example: L132 in src/replica/split/test/replica_split_test.cppapache/incubator-pegasus#887