Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: shutdown error while closing replica #1052

Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix: shutdown error while closing replica #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e39a0b
fix: shutdown error while close replica
hycdong Feb 10, 2022
aa663bd
Merge branch 'pegasus' into fix_shutting_down
hycdong Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions include/dsn/dist/replication/replication_app_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,6 @@ class replication_app_base : public replica_base
//
error_code open();

//
// Cancel all background flush and compaction work.
//
virtual void cancel_background_work(bool wait) {}

//
// Close the app.
// If `clear_state' is true, means clear the app state after close it.
Expand Down
4 changes: 0 additions & 4 deletions src/replica/replica.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,10 +434,6 @@ void replica::close()
_checkpoint_timer = nullptr;
}

if (_app != nullptr) {
hycdong marked this conversation as resolved.
Show resolved Hide resolved
_app->cancel_background_work(true);
}

_tracker.cancel_outstanding_tasks();

cleanup_preparing_mutations(true);
Expand Down