This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(dup_enhancement#20): put async_duplicate_checkpoint_from_master_replica into DEFAULT_POOL to avoid thread lock
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
commented
Mar 16, 2022
| _duplicating_checkpoint = true; | ||
| async_duplicate_checkpoint_from_master_replica(); | ||
| tasking::enqueue(LPC_DUPLICATE_CHECKPOINT, &_tracker, [=]() mutable { | ||
| async_duplicate_checkpoint_from_master_replica(); |
There was a problem hiding this comment.
For review: LPC_DUPLICATE_CHECKPOINT in DEFAULT_POOL, when execute _tracker.wait_outstanding_tasks(), it won't be lock
foreverneverer
changed the title
duplicate_checkpoint into DEFAULT_POOL to avoid thread lockasync_duplicate_checkpoint_from_master_replica into DEFAULT_POOL to avoid thread lock
levy5307
approved these changes
Mar 16, 2022
hycdong
approved these changes
Mar 16, 2022
foreverneverer
added a commit
that referenced
this pull request
Mar 29, 2022
…replica` into `DEFAULT_POOL` to avoid thread lock (#1076)
foreverneverer
added a commit
that referenced
this pull request
Mar 29, 2022
…replica` into `DEFAULT_POOL` to avoid thread lock (#1076)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref-Issue
apache/incubator-pegasus#892
Change
THREAD_POOL_REPLICATION_LONGhas limited count, whenduplicate_checkpointput into it andsync execute, it will be exhausted and casue thread lock, this pr fix it