This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: fix md5 lack during block service download #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
acelyc111
approved these changes
May 7, 2022
foreverneverer
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Pegasus#926 shows, to enhance the performance of bulk load, we support direct I/O when we download files from hdfs and update the download interface to calculate downloaded file size and md5.
However, #1074 only add md5 calculation for hdfs provider, lacking fds and local_service, which will lead that bulk load can not run on fds and local_service, for the md5 verification will be failed. This pull request fixs it.