This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(update_replication_factor#8): recover uncompleted update of replication factor during initialization of meta service #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication factor during initialization of meta service
…ication factor during initialization of meta service
…ication factor during initialization of meta service
…ication factor during initialization of meta service
…ication factor during initialization of meta service
Closed
11 tasks
acelyc111
reviewed
May 27, 2022
…ication factor during initialization of meta service
acelyc111
approved these changes
May 27, 2022
hycdong
approved these changes
Jun 1, 2022
acelyc111
pushed a commit
that referenced
this pull request
Jun 1, 2022
…ication factor during initialization of meta service (#1110)
acelyc111
pushed a commit
that referenced
this pull request
Jun 6, 2022
…ication factor during initialization of meta service (#1110)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtask of apache/incubator-pegasus#865.
Since in #1087 we've supported to set env for the replication factor in case there are duplicate requests trying to update the same table, there is still a problem that the request for updating replication factor may fail once meta server crashes. It's possible that there are partial steps finished while others are uncompleted.
Therefore, After meta server has got primary lock, it will initialize, during which recovering replication factor should be relaunched. Any table whose env of updating replication factor is not removed (once updating replication factor is complete, the env will be eliminated) will be the candidate that needs to recover as long as it's available. All tables should have been restored before the initialization is finished.