This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(security): receive mechanisms which are supported by server_negotiation #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
previously approved these changes
Aug 20, 2020
acelyc111
reviewed
Aug 20, 2020
acelyc111
previously approved these changes
Aug 22, 2020
neverchanje
approved these changes
Aug 24, 2020
acelyc111
approved these changes
Aug 24, 2020
levy5307
added
the
type/config-change
PR that made modification on configs, which should be noted in release note.
label
Oct 30, 2020
levy5307
added a commit
to levy5307/rdsn
that referenced
this pull request
Dec 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component/security
type/config-change
PR that made modification on configs, which should be noted in release note.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pr #588 , server_negotiation receives SASL_LIST_MECHANISMS request, and reply the mechanism that it supports. This pr is implemented to handle the
SASL_LIST_MECHANISMS_RESP
to get the mechanism supported byserver_negotiation
. And then select a mechanism which is supported by bothclient_negotiation
andserver_negotiation
.New configuration added
[security] + mandatory_auth = false