Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

refactor(backup): move cold_backup_context out to standalone file #619

Merged
merged 4 commits into from
Sep 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/common/replication_common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ replication_options::replication_options()

learn_app_max_concurrent_count = 5;

max_concurrent_uploading_file_count = 10;

cold_backup_checkpoint_reserve_minutes = 10;
}

Expand Down Expand Up @@ -510,12 +508,6 @@ void replication_options::initialize()
cold_backup_root = dsn_config_get_value_string(
"replication", "cold_backup_root", "", "cold backup remote storage path prefix");

max_concurrent_uploading_file_count =
(int32_t)dsn_config_get_value_uint64("replication",
"max_concurrent_uploading_file_count",
max_concurrent_uploading_file_count,
"concurrent uploading file count");

cold_backup_checkpoint_reserve_minutes =
(int)dsn_config_get_value_uint64("replication",
"cold_backup_checkpoint_reserve_minutes",
Expand Down
1 change: 0 additions & 1 deletion src/common/replication_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class replication_options
int32_t learn_app_max_concurrent_count;

std::string cold_backup_root;
int32_t max_concurrent_uploading_file_count;
int32_t cold_backup_checkpoint_reserve_minutes;

std::string bulk_load_provider_root;
Expand Down
3 changes: 2 additions & 1 deletion src/replica/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ set(DUPLICATION_SRC
duplication/mutation_batch.cpp
)

set(BACKUP_SRC backup/replica_backup_manager.cpp)
set(BACKUP_SRC backup/replica_backup_manager.cpp
backup/cold_backup_context.cpp)

set(BULK_LOAD_SRC bulk_load/replica_bulk_loader.cpp)

Expand Down
Loading