This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(security): add join point to filter the sending message #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found these PRs will add many if-statements, it's better to add some branch predictions, i.e. |
acelyc111
reviewed
Sep 18, 2020
hycdong
reviewed
Sep 21, 2020
acelyc111
approved these changes
Sep 21, 2020
hycdong
approved these changes
Sep 22, 2020
neverchanje
reviewed
Sep 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add join point to filter the sending message. If a message is filtered by
negotiation_service::on_rpc_send_msg, we will put it into a pending message queue, which name is_pending_messagesinrpc_session, and resend it when the negotiation is succeed.