Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: fix fds_service_test #635

Merged
merged 4 commits into from
Oct 10, 2020
Merged

fix: fix fds_service_test #635

merged 4 commits into from
Oct 10, 2020

Conversation

zhangyifan27
Copy link
Contributor

  • fix tests, now test could pass with correct fds settings.
  • do not check meta before read/download, because we would call get_file_meta() in fds_file_object::get_content_in_batches().
  • when download failed, we should remove existing local file.
  • other code cleanup.

@zhangyifan27 zhangyifan27 changed the title fix(fds_service): fix tests fix: fix fds_service_test Sep 30, 2020
acelyc111
acelyc111 previously approved these changes Oct 4, 2020
View reviewed changes
@zhangyifan27 zhangyifan27 merged commit 2597bfc into XiaoMi:master Oct 10, 2020
hycdong pushed a commit that referenced this pull request Dec 29, 2020
@zhangyifan27 @hycdong
fix: fix fds_service_test (#635)
da0dc6f
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangyifan27 @acelyc111 @levy5307 @neverchanje