Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix(security): fix bug in negotiation_service::on_negotiation_request when rpc_session is closed #652

Merged
merged 18 commits into from
Nov 4, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/runtime/security/negotiation_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ void negotiation_service::on_negotiation_request(negotiation_rpc rpc)
static_cast<server_negotiation *>(_negotiations[rpc.dsn_request()->io_session].get());
}

dassert(srv_negotiation != nullptr,
"negotiation is null for msg: {}",
rpc.dsn_request()->rpc_code().to_string());
if (nullptr == srv_negotiation) {
ddebug("negotiation is null for msg: {}", rpc.dsn_request()->rpc_code().to_string());
neverchanje marked this conversation as resolved.
Show resolved Hide resolved
return;
}
srv_negotiation->handle_request(rpc);
}

Expand Down