Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat(hotkey): Change RPC to query hotkey #700

Merged
merged 3 commits into from
Dec 24, 2020
Merged

feat(hotkey): Change RPC to query hotkey #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5dff98
update rpc
Smityz Dec 22, 2020
0b07a63
format
Smityz Dec 22, 2020
ac67187
Merge branch 'master' into query
hycdong Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions include/dsn/dist/replication/replication_types.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 30 additions & 3 deletions src/common/replication_types.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/replica/replica_stub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2788,7 +2788,6 @@ void replica_stub::on_group_bulk_load(group_bulk_load_rpc rpc)
}
}

// TODO: (Tangyanzhao) implement it later
void replica_stub::on_detect_hotkey(detect_hotkey_rpc rpc)
{
const auto &request = rpc.request();
Expand Down
4 changes: 3 additions & 1 deletion src/replication.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,8 @@ enum hotkey_type
enum detect_action
{
START,
STOP
STOP,
QUERY
}

enum disk_migration_status {
Expand All @@ -1167,6 +1168,7 @@ struct detect_hotkey_response {
// - ERR_SERVICE_ALREADY_EXIST: hotkey detection is running now
1: dsn.error_code err;
2: optional string err_hint;
3: optional string hotkey_result;
}

/*
Expand Down