This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: don't resend message if it is rejected by server #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
levy5307
commented
Jan 8, 2021
•
levy5307
commented
- Don't resend message if it is rejected by server. because it means that the server is overload if it reject this message. So if we resend the message, it will makes the situation even worse.
- use cflags to define cluster_name. But we can't use flag validator, because cpp client will not set cluster name. so the validator will always fail for it
neverchanje
reviewed
Jan 8, 2021
neverchanje
approved these changes
Jan 8, 2021
hycdong
approved these changes
Jan 11, 2021
foreverneverer
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.