This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(bulk_load): redownload file if local file damaged #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Apr 26, 2021
neverchanje
approved these changes
Apr 27, 2021
levy5307
approved these changes
Apr 27, 2021
hycdong
added a commit
that referenced
this pull request
May 7, 2021
hycdong
added a commit
that referenced
this pull request
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bulk load download stage, replica server will download file from remote file provider, if a same-name file exists, block service interface
download_filewill returnERR_PATH_ALREADY_EXIST. In previous implmentation, if local file doesn't pass verification, it will lead to bulk load failed. This pull request fixs it, if local file doesn't pass verifition, it will remove old file and redownload it.I test this case in onebox manually in following step: