Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tosa constant folding for matmul. #111

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

ttjost
Copy link

@ttjost ttjost commented Feb 26, 2024

Inputs and results were generated with pytorch.

We now also support Quantized Int8. The test uses same data as found in

func.func @quantized_matmul(%input1: tensor<5x3xi8>,

@ttjost ttjost requested review from mgehre-amd and TinaAMD February 26, 2024 09:14
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few comments

mlir/test/Dialect/Tosa/constant-matmul.mlir Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/test/Dialect/Tosa/constant-matmul.mlir Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 26, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@ttjost ttjost requested review from mgehre-amd and TinaAMD February 26, 2024 17:22
Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/lib/Dialect/Tosa/Transforms/TosaFolders.cpp Outdated Show resolved Hide resolved
mlir/test/Dialect/Tosa/constant-matmul.mlir Outdated Show resolved Hide resolved
mlir/test/Dialect/Tosa/constant-matmul.mlir Outdated Show resolved Hide resolved
@ttjost ttjost force-pushed the tiagot.constant_fold_matmul branch from c977444 to 8f04065 Compare February 27, 2024 08:23
@ttjost ttjost merged commit e5ea0c4 into feature/fused-ops Feb 27, 2024
3 checks passed
@ttjost ttjost deleted the tiagot.constant_fold_matmul branch February 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants