Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir][emitc] Implement arith.negf to EmitC #194

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

TinaAMD
Copy link

@TinaAMD TinaAMD commented Jun 5, 2024

Convert arith.negf to emitc.unary_minus. Did not see any special cases here, so use a straight forward translation.

@TinaAMD TinaAMD requested review from cferry-AMD and josel-amd June 5, 2024 07:12
Copy link
Collaborator

@cferry-AMD cferry-AMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There really seems to be nothing special with the negation of a floating-point number that would make it illegal, so this is alright as far as I can tell. Thanks for doing it!

Copy link
Collaborator

@josel-amd josel-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaAMD TinaAMD merged commit a6f8295 into feature/fused-ops Jun 5, 2024
4 checks passed
@TinaAMD TinaAMD deleted the tina.FXML-4644-arith-negf branch June 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants