Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose skipRegions option for Op printing in the C and Python bindings #202

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

jorickert
Copy link

@jorickert jorickert commented Jun 18, 2024

The MLIR C and Python Bindings expose various methods from mlir::OpPrintingFlags . This PR adds a binding for the skipRegions method, which allows to skip the printing of Regions when printing Ops. It also exposes this option as parameter in the python get_asm and print methods

@jorickert jorickert requested a review from cmcgirr-amd June 18, 2024 12:10
@jorickert jorickert force-pushed the jrickert.expose_skip_regions branch from fffd3b8 to 57e123b Compare June 18, 2024 12:32
@cmcgirr-amd cmcgirr-amd requested a review from ttjost June 19, 2024 07:01
@mgehre-amd
Copy link
Collaborator

I'm worried that this will cause issues when bumping llvm unless this is upstreamed right away. What are your plans for upstreaming?

@jorickert jorickert changed the title Expose skipRegions options for Op printing in the C and Python bindings Expose skipRegions option for Op printing in the C and Python bindings Jun 19, 2024
@jorickert jorickert force-pushed the jrickert.expose_skip_regions branch 2 times, most recently from 3f9acc0 to a2f46b3 Compare June 19, 2024 15:06
@jorickert jorickert removed the request for review from ttjost June 20, 2024 08:47
@jorickert jorickert merged commit f619673 into feature/fused-ops Jun 20, 2024
3 checks passed
@jorickert jorickert deleted the jrickert.expose_skip_regions branch June 20, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants