Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify #once on .pdll to enable better modular "header" inclusion #210

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

roberteg16
Copy link

@roberteg16 roberteg16 commented Jul 8, 2024

This eases developing .pdll files with the help of mlir-pdll-lsp-server

Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this feature, thanks! I added a few comments that I would like to see resolved.

@roberteg16 roberteg16 force-pushed the rogarcia.add_#once_to_pdll branch from 2057276 to 293e14a Compare July 8, 2024 13:36
@roberteg16 roberteg16 requested a review from mgehre-amd July 8, 2024 13:44
@roberteg16 roberteg16 force-pushed the rogarcia.add_#once_to_pdll branch from 293e14a to 9be142b Compare July 8, 2024 13:44
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roberteg16 roberteg16 removed the request for review from ehsan-toosi July 9, 2024 07:04
@roberteg16 roberteg16 merged commit 612aed5 into feature/fused-ops Jul 9, 2024
3 checks passed
@roberteg16 roberteg16 deleted the rogarcia.add_#once_to_pdll branch July 9, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants