EmitC: Allow arrays of size zero #255
Conversation
This is allowed as a GCC extension, see https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html and helps to make the lowering code more uniform.
There was a problem hiding this comment.
This deviates from C99:
In addition to optional type qualifiers and the keyword static, the [ and ] may delimit
an expression or *. If they delimit an expression (which specifies the size of an array), the
expression shall have an integer type. If the expression is a constant expression, it shall
have a value greater than zero.
Should we mention that in mlir/docs/Dialects/emitc.md?
Done! |
This is allowed as a GCC extension, see https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html.
It's helpful when coming from tensors with zero size dimensions to make the lowering code more uniform.