EmitC: Use brace initialization for values of opaque type when lowering ub.posion #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting from UB to EmitC, we have no means to identify a proper initial value when the type is opaque. Report a match failure.
cferry-AMD
approved these changes
Jan 6, 2025
|
Do you still want to merge this? |
I'll update it and re-request reviews. |
Values of opaque type are currently initialized to integers, which may be invalid. Instead, lower them using brace-initializers. The emitc code will represent C++.
TinaAMD
changed the title
|
Upstream will ask you to update https://mlir.llvm.org/docs/Dialects/EmitC/ with the C++ when ... condition. (This is some doc file in the repo) |
Thanks for the pointer! Added it. |
cferry-AMD
approved these changes
Jan 6, 2025
josel-amd
approved these changes
Jan 9, 2025
josel-amd
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values of opaque type are currently initialized to integers, which may be invalid. Instead, lower them using brace-initializers. The emitc code will represent C++.
Comes without a test since there are currently no types I am aware of that are converted to opaque types.