Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoBump] Merge with fixes of 217700ba (Oct 30) (4) (Needs downstream changes) #461

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

jorickert
Copy link

@jorickert jorickert commented Jan 31, 2025

I reverted #205 as bufferization now handles bodyless functions, so no extra flag is required. Downstream will need to remove usage of this flag

matthias-springer and others added 3 commits October 30, 2024 21:49
…vm#113999)

This commit adds support for bufferizing external functions that have no
body. Such functions were previously rejected by One-Shot Bufferize if
they returned a tensor value.

This commit is in preparation of removing the deprecated
`func-bufferize` pass. That pass can bufferize external functions.

Also update a few comments.
…sults option"

This reverts commit 151f763, except for the test added by it
@jorickert jorickert changed the title [AutoBump] Merge with fixes of 217700ba (Oct 30) (4) [AutoBump] Merge with fixes of 217700ba (Oct 30) (4) (Needs downstream changes) Jan 31, 2025
@jorickert jorickert requested a review from mgehre-amd February 3, 2025 07:31
Copy link
Collaborator

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from bump_to_ea050ab1 to bump_to_2e43a304 February 3, 2025 08:57
@jorickert jorickert merged commit 0a6b32b into bump_to_2e43a304 Feb 3, 2025
4 checks passed
@jorickert jorickert deleted the bump_to_217700ba branch February 3, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants