forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new tosa verifiers #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
Jan 12, 2024
mgehre-amd
reviewed
Jan 12, 2024
mgehre-amd
reviewed
Jan 12, 2024
mgehre-amd
reviewed
Jan 12, 2024
mgehre-amd
reviewed
Jan 12, 2024
Hey, thanks for the verifiers! I added a few comments. In general, I'd prefer small PRs, i.e. one PR per verifier. |
mgehre-amd
reviewed
Jan 12, 2024
Revert code formatting for existing code Fixed uninitialized local variable usage
mgehre-amd
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only open comment is about whether the llvm::cast / assuming ShapedType is fine.
mgehre-amd
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing verifiers for concat, pad as per the tosa spec.
A brief list of cases covered in each verifier:
concat
pad