performance: remove extra conversions and optimize functions

[JukLee0ira]

Proposed changes

• Removed unnecessary string conversions, using binary forms of special addresses for direct bit comparisons to cut conversion costs and speed up comparisons.
• Reduced repeated calls by introducing local variables to cache results, minimizing multiple calculations of the same expression, thus boosting performance.
• Simplified code expressions for easier readability and maintenance.
• Wrote unit tests to ensure consistent function behavior before and after optimization.

Example 1

• Before: Checks quoteToken as string, converts common.XDCNativeAddress hex to address

if order.QuoteToken().String() != common.XDCNativeAddress {
		quotePrice = XDCxStateDb.GetLastPrice(GetTradingOrderBookHash(order.QuoteToken(),common.HexToAddress(common.XDCNativeAddress)))
		log.Debug("TryGet quotePrice QuoteToken/XDC", "quotePrice", quotePrice)
}

• After: Directly compares common.XDCNativeAddressBinary by binary form, fetches price without conversion.

if order.QuoteToken() != common.XDCNativeAddressBinary {
		quotePrice = XDCxStateDb.GetLastPrice(GetTradingOrderBookHash(order.QuoteToken(), common.XDCNativeAddressBinary))
		log.Debug("TryGet quotePrice QuoteToken/XDC", "quotePrice", quotePrice)
}

Example 2

• Before: Check token string equality with common.XDCNativeAddress and log with string conversions.

if token.String() == common.XDCNativeAddress {
		balance := statedb.GetBalance(addr)
		log.Debug("ApplyXDCXMatchedTransaction settle balance: SUB XDC NATIVE BALANCE BEFORE", "token", token.String(), "address", addr.String(), "balance", balance, "orderValue", value)
}

• After: With the value of token known as XDCNativeAddress, use its string type directly.

if token == common.XDCNativeAddressBinary {
		balance := statedb.GetBalance(addr)
		log.Debug("ApplyXDCXMatchedTransaction settle balance: SUB XDC NATIVE BALANCE BEFORE", "token", common.XDCNativeAddress, "address", addr.String(), "balance", balance, "orderValue", value)
}

Example 3

• Before: There were many type conversion functions and repetitive calls to the To() function to retrieve the same result in the logic.

func (tx *Transaction) IsSpecialTransaction() bool {
	if tx.To() == nil {
		return false
	}
	toBytes := tx.To().Bytes()
	randomizeSMCBytes := common.HexToAddress(common.RandomizeSMC).Bytes()
	blockSignersBytes := common.HexToAddress(common.BlockSigners).Bytes()
	return bytes.Equal(toBytes, randomizeSMCBytes) || bytes.Equal(toBytes, blockSignersBytes)
}

• After: Direct bit comparison is used, and the result of tx.To() is stored in a variable for reuse, leading to a more streamlined and easily comprehensible code structure.

func (tx *Transaction) IsSpecialTransaction() bool {
	to := tx.To()
	return to != nil && (*to == common.RandomizeSMCBinary || *to == common.BlockSignersBinary)
}

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement
• Performance

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[gzliudan]

Please also change skipNonceDestinationAddress = map[string]bool to skipNonceDestinationAddress = map[common.Address]bool or skipNonceDestinationAddress = map[common.Address]struct{}. The latter one is better.

[gzliudan]

LGTM

[liam-icheng-lai]

Good Improvement

[liam-lai]

Good improvement