Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some panic cuased by nil block, statedb, header #578

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Fix some panic cuased by nil block, statedb, header #578

merged 6 commits into from
Aug 3, 2024

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jul 12, 2024 •
edited
Loading

Proposed changes

This PR fixes some panic caused by nil block, header, statedb, such as #271.

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

wgr523
wgr523 reviewed Jul 12, 2024
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
wgr523
wgr523 reviewed Jul 12, 2024
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
wgr523
wgr523 reviewed Jul 12, 2024
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
wgr523
wgr523 reviewed Jul 12, 2024
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
@gzliudan gzliudan force-pushed the fix-nil-block branch 3 times, most recently from ed09504 to b31ed88 Compare July 12, 2024 23:20
@gzliudan gzliudan force-pushed the fix-nil-block branch 4 times, most recently from 7b94b92 to 01c6e75 Compare July 13, 2024 04:29
@gzliudan gzliudan changed the title Fix nil block and statedb Fix some panic cuased by nil block, statedb, header Jul 13, 2024
@gzliudan gzliudan requested a review from wgr523 July 13, 2024 04:45
liam-lai
liam-lai reviewed Jul 14, 2024
View reviewed changes
eth/api_backend.go Outdated Show resolved Hide resolved
@gzliudan gzliudan changed the base branch from dev-upgrade to master July 14, 2024 07:21
@gzliudan gzliudan force-pushed the fix-nil-block branch 2 times, most recently from 80564bb to e1a76de Compare July 14, 2024 07:49
@gzliudan gzliudan force-pushed the fix-nil-block branch 2 times, most recently from 9711d57 to c03b1cd Compare July 15, 2024 04:14
@gzliudan gzliudan changed the base branch from master to dev-upgrade July 22, 2024 07:09
@liam-lai liam-lai merged commit 4976b7c into XinFinOrg:dev-upgrade Aug 3, 2024
17 checks passed
@gzliudan gzliudan deleted the fix-nil-block branch August 3, 2024 00:09
wanwiset25 pushed a commit that referenced this pull request Aug 23, 2024
@gzliudan @wanwiset25
Fix some panic cuased by nil block, statedb, header (#578)
540ff05 
* fix panic during rollback

* eth/hooks: check nil stateDB to fix issue #271

* internal/ethapi: fix eth_call crash

* all: check nil statedb

* eth: check nil block for tracer api

* internal/ethapi: check nil header and block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wgr523 wgr523 wgr523 approved these changes

@liam-lai liam-lai liam-lai approved these changes

@wjrjerome wjrjerome wjrjerome approved these changes

@AnilChinchawale AnilChinchawale Awaiting requested review from AnilChinchawale

@wanwiset25 wanwiset25 Awaiting requested review from wanwiset25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gzliudan @wjrjerome @liam-lai @wgr523