Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix database corrupt when UpdateM1 fails during reorg #596

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jul 31, 2024

Proposed changes

If node exit abnormally because UpdateM1() return error during reorg, the database become corrupted. When we start node at this time, the node will complain:

Fatal: Error starting protocol stack: missing block number for head header hash

This PR keep database in normal state when UpdateM1() fails by save the incoming blocks during reorg.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title fix database corrupt when exit abnormally during reorg fix database corrupt when UpdateM1 fails during reorg Jul 31, 2024
Copy link
Collaborator

@wanwiset25 wanwiset25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liam-lai liam-lai merged commit e9e94e6 into XinFinOrg:dev-upgrade Aug 2, 2024
17 checks passed
@gzliudan gzliudan deleted the fix-db-corrupt branch August 2, 2024 23:54
@liam-lai
Copy link
Collaborator

liam-lai commented Aug 2, 2024

Below's code only insert the latest reorg block, it doesn't insert the parents, so that if it panic in between reorg, then block insert only insert the header but not the body. Cause block chain data corrupted.

	batch := bc.db.NewBatch()
	if err := WriteBlock(batch, block); err != nil {
		return NonStatTy, err
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants