Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotes not working with WezTerm under Windows 11 #538

Closed
FlamingPhoenix40 opened this issue Feb 14, 2024 · 8 comments
Closed

Emotes not working with WezTerm under Windows 11 #538

FlamingPhoenix40 opened this issue Feb 14, 2024 · 8 comments

Comments

@FlamingPhoenix40
Copy link

Describe the bug:
Found your program, wanted to try it out on my main Windows 11 installation. Followed instructions to install, installed WezTerm because I wanted to try it out with the emote support turned on. With default settings, program works fine. However, as soon as I turn emote support on in the config file, I get the error message:
"This terminal does not support the graphics protocol.
Use a terminal such as kitty or WezTerm, or disable emotes."

even though I'm calling the program from WezTerm.

To Reproduce:

  1. Install twt from Rust Cargo.
  2. Install WezTerm from official Windows Binary
  3. Walk through initial setup provided when running twt for first time
  4. edit config.toml to enable emote support
  5. start twt from WezTerm
  6. twt doesn't start but gives error message about unsupported terminal

Expected behavior:
twt starts with emote support enabled

Screenshots:

image
image

System:

  • Twitch-tui version: 2.6.3
  • Operating System: Windows 11 23H2
  • Terminal: WezTerm 20240203-110809-5046fc22
  • Shell: tried both default cmd.exe in WezTerm as well as bash 5.2.15(1)-release

Additional context:
Add any other context about the problem here.
Could be that I'm very much missing something while setting everything up here, but as far as I can tell from the official documentation from twt, I should have done everything right.

@Xithrius
Copy link
Owner

Xithrius commented Feb 14, 2024

Hello! Thank you for the issue. I believe you're doing everything right so far, and I think I've already found the cause of the problem. I'll get back to you on that once I can reproduce it.

@Nogesma
Copy link
Contributor

Nogesma commented Feb 18, 2024

I think it's my bad for not updating the message, I dropped Wezterm support when I introduced unicode placeholders, as Wezterm does not support it yet.
You can check on this issue wez/wezterm#986 to see progress on implementation of the graphics procotol for Wezterm.

I think twt version 2.6.1 is the last one which doesn't use unicode placeholders, so it should work with wezterm, although I don't have windows so I cannot test it on there.

@Xithrius
Copy link
Owner

Xithrius commented Feb 18, 2024

Ah, I see. I thought the solution was that this && operator was supposed to be an || operator. Tested it, broke many things.

@Nogesma
Copy link
Contributor

Nogesma commented Feb 19, 2024

Well, terminal emulators that do not support graphics protocol should ignore the graphics protocol query in theory, but some do not, and some terminals do not even respond to the send device attribute query csi!("c"), which would result in an infinite loop.
That's why I added the env check, as kitty will always respond to those queries correctly.

If it is needed I can look into adding back the code to display emotes without unicode placeholders behind a feature flag, but the code is a lot more complicated than when using unicode placeholders. There is also a few bugs in there like #530.

@mspi21

This comment was marked as resolved.

@Xithrius

This comment was marked as resolved.

@AnonymouX47
Copy link

Even if Wezterm did support Unicode placeholders, there's no point trying it on Windows anyways.

See wez/wezterm#1673.

@Xithrius
Copy link
Owner

Xithrius commented Mar 4, 2024

I'll mark this as closed for now. Error message has been updated to reflect what twt currently supports.

@Xithrius Xithrius closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants