Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitty image protocol does not display images on Windows #1673

Open
Superchig opened this issue Feb 28, 2022 · 4 comments
Open

Kitty image protocol does not display images on Windows #1673

Superchig opened this issue Feb 28, 2022 · 4 comments
Labels
bug Something isn't working Windows Issue applies to Microsoft Windows

Comments

@Superchig
Copy link

Superchig commented Feb 28, 2022

What Operating System(s) are you seeing this problem on?

Windows

WezTerm version

20220227-125650-82da9074

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

No image is displayed when using the Kitty image protocol with wezterm on Windows.

To Reproduce

  1. Download kitty-png.py.
  2. Download this image file and name it bash-logo.png
  3. Run python3 kitty-png.py bash-logo.png while in Wezterm.
  4. See that no image is displayed.

Configuration

no config

Expected Behavior

When running python3 kitty-png.py bash-logo.png, an image of the bash logo should be displayed.

Logs

20:29:14.124 INFO wezterm_mux_server_impl::local > setting up C:\Users\chigg.local/share/wezterm\gui-sock-3468
20:29:14.126 INFO wezterm_client::discovery::windows > published gui path as gui-sock-3468
20:29:14.204 WARNING window::os::windows::window > EGL init failed Config says to avoid EGL, fall back to WGL
20:29:14.326 INFO wezterm_gui::termwindow > OpenGL initialized! NVIDIA GeForce RTX 2060/PCIe/SSE2 4.5.0 NVIDIA 511.65 is_context_loss_possible=true wezterm version: 20220227-125650-82da9074

Anything else?

No response

@Superchig Superchig added the bug Something isn't working label Feb 28, 2022
@wez
Copy link
Owner

wez commented Feb 28, 2022

This is the same root cause as #1236, which is that the ConPTY layer in Windows swallows these escape sequences.

We're waiting on some combination of:
microsoft/terminal#1173
microsoft/terminal#448

before this will work directly on ConPTY

In the meantime, you might consider using either wezterm's multiplexing feature or wezterm ssh to bypass conpty.

@wez wez added the Windows Issue applies to Microsoft Windows label Feb 28, 2022
@Superchig
Copy link
Author

Thanks for the workaround suggestions!

I tried using the Unix socket on Windows, but the kitty image protocol still doesn't seem to display an image.

I was using this in the config:

return {
  unix_domains = {
    {
      name = "unix",
    }
  },

  -- This causes `wezterm` to act as though it was started as
  -- `wezterm connect unix` by default, connecting to the unix
  -- domain on startup.
  -- If you prefer to connect manually, leave out this line.
  default_gui_startup_args = {"connect", "unix"},
}

Can the Unix socket work for this, or should I use wezterm ssh/multiplexing with WSL?

@wez
Copy link
Owner

wez commented Mar 12, 2022

Ah, you probably just want wezterm ssh. There are some limitations with multiplexing and handling image protocols at the moment (#1237)

@AnonymouX47
Copy link

AnonymouX47 commented Aug 30, 2024

@wez, I think this might be worth looking into, now that microsoft/terminal#1173 has been resolved.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Windows Issue applies to Microsoft Windows
Projects
None yet
Development

No branches or pull requests

3 participants